[SharedUX][A11y] Fix tag selector missing error text #241443
Merged
+61
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angeles-mb
added
backport:version
|
@elasticmachine run docs-build-pr |
nickpeihl
approved these changes
Oct 31, 2025
|
/ci |
bhavyarm
approved these changes
Oct 31, 2025
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @angeles-mb |
|
Starting backport for target branches: 9.2 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
angeles-mb
added a commit
to angeles-mb/kibana
that referenced
this pull request
Nov 3, 2025
Closes elastic#237856 ## Summary - Added differentiated error messages for the `TagSelector` for the following use cases: - Tag doesn't exist: - If user has permissions, prompt to create it - If they don't, prompt to select one from the list - Tag exists, prompt to select it - Tag exists and it is already selected - This change should fix all occurrences of the missing error message for the `TagSelector`. - For the Settings flyout, instead of directly using the `TagSelector` we are now using the wrapper containing this validation logic, there should be no other changes. ### Testing Flyout Settings: https://github.com/user-attachments/assets/461772cc-40d5-43c2-8c7d-e0571d9f93f8 Dashboard Details: https://github.com/user-attachments/assets/3005cd63-9775-484a-804f-de9bcb2c381f Error announcement on VO: <img width="642" height="673" alt="Screenshot 2025-10-31 at 12 04 46" src="https://github.com/user-attachments/assets/7e387d5e-2df2-4968-8fd1-10daf03db6fd" /> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 9eb3ad3) # Conflicts: # src/platform/plugins/shared/dashboard/public/dashboard_renderer/settings/settings_flyout.tsx
angeles-mb
added a commit
that referenced
this pull request
Nov 3, 2025
Closes #237856 ## Summary - Added differentiated error messages for the `TagSelector` for the following use cases: - Tag doesn't exist: - If user has permissions, prompt to create it - If they don't, prompt to select one from the list - Tag exists, prompt to select it - Tag exists and it is already selected - This change should fix all occurrences of the missing error message for the `TagSelector`. - For the Settings flyout, instead of directly using the `TagSelector` we are now using the wrapper containing this validation logic, there should be no other changes. ### Testing Flyout Settings: https://github.com/user-attachments/assets/461772cc-40d5-43c2-8c7d-e0571d9f93f8 Dashboard Details: https://github.com/user-attachments/assets/3005cd63-9775-484a-804f-de9bcb2c381f Error announcement on VO: <img width="642" height="673" alt="Screenshot 2025-10-31 at 12 04 46" src="https://github.com/user-attachments/assets/7e387d5e-2df2-4968-8fd1-10daf03db6fd" /> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 9eb3ad3) # Conflicts: # src/platform/plugins/shared/dashboard/public/dashboard_renderer/settings/settings_flyout.tsx
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
angeles-mb
added a commit
that referenced
this pull request
Nov 5, 2025
…241654) # Backport This will backport the following commits from `main` to `9.2`: - [[SharedUX][A11y] Fix tag selector missing error text (#241443)](#241443) <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ángeles Martínez Barrio","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-11-03T15:17:06Z","message":"[SharedUX][A11y] Fix tag selector missing error text (#241443)\n\nCloses https://github.com/elastic/kibana/issues/237856\n\n## Summary\n\n- Added differentiated error messages for the `TagSelector` for the\nfollowing use cases:\n - Tag doesn't exist:\n - If user has permissions, prompt to create it\n - If they don't, prompt to select one from the list\n - Tag exists, prompt to select it\n - Tag exists and it is already selected\n- This change should fix all occurrences of the missing error message\nfor the `TagSelector`.\n- For the Settings flyout, instead of directly using the `TagSelector`\nwe are now using the wrapper containing this validation logic, there\nshould be no other changes.\n\n### Testing\n\nFlyout Settings:\n\n\nhttps://github.com/user-attachments/assets/461772cc-40d5-43c2-8c7d-e0571d9f93f8\n\nDashboard Details:\n\n\nhttps://github.com/user-attachments/assets/3005cd63-9775-484a-804f-de9bcb2c381f\n\nError announcement on VO:\n\n<img width=\"642\" height=\"673\" alt=\"Screenshot 2025-10-31 at 12 04 46\"\nsrc=\"https://github.com/user-attachments/assets/7e387d5e-2df2-4968-8fd1-10daf03db6fd\"\n/>\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9eb3ad35ea648576365ebac5539bfadfff66c6e7","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:cloud-deploy","backport:version","v9.3.0","v9.2.1"],"title":"[SharedUX][A11y] Fix tag selector missing error text","number":241443,"url":"https://github.com/elastic/kibana/pull/241443","mergeCommit":{"message":"[SharedUX][A11y] Fix tag selector missing error text (#241443)\n\nCloses https://github.com/elastic/kibana/issues/237856\n\n## Summary\n\n- Added differentiated error messages for the `TagSelector` for the\nfollowing use cases:\n - Tag doesn't exist:\n - If user has permissions, prompt to create it\n - If they don't, prompt to select one from the list\n - Tag exists, prompt to select it\n - Tag exists and it is already selected\n- This change should fix all occurrences of the missing error message\nfor the `TagSelector`.\n- For the Settings flyout, instead of directly using the `TagSelector`\nwe are now using the wrapper containing this validation logic, there\nshould be no other changes.\n\n### Testing\n\nFlyout Settings:\n\n\nhttps://github.com/user-attachments/assets/461772cc-40d5-43c2-8c7d-e0571d9f93f8\n\nDashboard Details:\n\n\nhttps://github.com/user-attachments/assets/3005cd63-9775-484a-804f-de9bcb2c381f\n\nError announcement on VO:\n\n<img width=\"642\" height=\"673\" alt=\"Screenshot 2025-10-31 at 12 04 46\"\nsrc=\"https://github.com/user-attachments/assets/7e387d5e-2df2-4968-8fd1-10daf03db6fd\"\n/>\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9eb3ad35ea648576365ebac5539bfadfff66c6e7"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/241443","number":241443,"mergeCommit":{"message":"[SharedUX][A11y] Fix tag selector missing error text (#241443)\n\nCloses https://github.com/elastic/kibana/issues/237856\n\n## Summary\n\n- Added differentiated error messages for the `TagSelector` for the\nfollowing use cases:\n - Tag doesn't exist:\n - If user has permissions, prompt to create it\n - If they don't, prompt to select one from the list\n - Tag exists, prompt to select it\n - Tag exists and it is already selected\n- This change should fix all occurrences of the missing error message\nfor the `TagSelector`.\n- For the Settings flyout, instead of directly using the `TagSelector`\nwe are now using the wrapper containing this validation logic, there\nshould be no other changes.\n\n### Testing\n\nFlyout Settings:\n\n\nhttps://github.com/user-attachments/assets/461772cc-40d5-43c2-8c7d-e0571d9f93f8\n\nDashboard Details:\n\n\nhttps://github.com/user-attachments/assets/3005cd63-9775-484a-804f-de9bcb2c381f\n\nError announcement on VO:\n\n<img width=\"642\" height=\"673\" alt=\"Screenshot 2025-10-31 at 12 04 46\"\nsrc=\"https://github.com/user-attachments/assets/7e387d5e-2df2-4968-8fd1-10daf03db6fd\"\n/>\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9eb3ad35ea648576365ebac5539bfadfff66c6e7"}},{"branch":"9.2","label":"v9.2.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #237856
Summary
TagSelectorfor the following use cases:TagSelector.TagSelectorwe are now using the wrapper containing this validation logic, there should be no other changes.Testing
Flyout Settings:
Screen.Recording.2025-10-31.at.12.03.03.mov
Dashboard Details:
Screen.Recording.2025-10-31.at.12.03.52.mov
Error announcement on VO: